Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output file includes closed findings #3

Open
svanschie opened this issue Jul 12, 2023 · 0 comments
Open

Output file includes closed findings #3

svanschie opened this issue Jul 12, 2023 · 0 comments

Comments

@svanschie
Copy link

After the scan is finished, the GetFindings call is used to retrieve the findings of the scan. When doing a revised scan after resolving some findings in your code, this API call still returns the (now closed) findings and are marked with status=Closed.

This status currently isn't actively used by the codeguru Python module in the Docker image. Because of this, the output file generated includes closed findings. The SARIF and SAST formats however don't include the finding status, so you have no way to differentiate it yourself.

The GetFinding call supports the status argument which allows retrieving only open findings, which I think would be the best solution to resolve the issue.

@svanschie svanschie reopened this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant