Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if AWS::CloudFormation::CustomResource.ServiceTimeout is not defined #3834

Open
1 of 2 tasks
ConnorKirk opened this issue Nov 19, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@ConnorKirk
Copy link

Is this feature request related to a new rule or cfn-lint capabilities?

rules

Describe the feature you'd like to request

Warn if a custom resource does not have a ServiceTimeout property set.

Describe the solution you'd like

Add a rule to warn if either the AWS::CloudFormation::CustomResource or Custom::* resource types don't have theServiceTimeout property set.

Additional context

Most users probably want to set the ServiceTimeout property for custom resources to a value lower than the default 60 minutes. This improves the developer and user experience by failing fast if there's an issue with the custom resource. It is very painful waiting 60 minutes for the custom resource to time out if you forget to set this parameter.

You can make a custom rule, but it doesn't catch uses of Custom::<Something> resource types
AWS::CloudFormation::CustomResource ServiceTimeout IS DEFINED WARN "Set a ServiceTimeout for the Custom resource"

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request

Would this feature include a breaking change?

  • ⚠️ This feature might incur a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant