Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AwsCdkCli: cdk deploy tries automatic rollback even when --no-rollback specified #32295

Open
1 task
dsturnbull opened this issue Nov 26, 2024 · 3 comments · May be fixed by #32309
Open
1 task

AwsCdkCli: cdk deploy tries automatic rollback even when --no-rollback specified #32295

dsturnbull opened this issue Nov 26, 2024 · 3 comments · May be fixed by #32309
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@dsturnbull
Copy link

Describe the bug

I run cdk deploy X --no-rollback, and some failure happened. CDK reports:

X: deploying... [1/1]
X: creating CloudFormation changeset...
Stack is in a paused fail state and command line arguments do not include "--no-rollback". Roll back first and then proceed with deployment (y/n)?

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I believe that if --no-rollback is supplied, automatic rollback should clearly be disabled, and also we should not be presented with an incorrect message

Current Behavior

CDK attempts reports incorrect message

Reproduction Steps

Contrive a non-fatal transient cloudformation error such that you would normally attempt a redeploy after some time.

Possible Solution

Disable automatic rollback if --no-rollback supplied.

Additional Information/Context

No response

CDK CLI Version

2.170.0

Framework Version

No response

Node.js Version

18.20.4

OS

macOS

Language

TypeScript

Language Version

No response

Other information

No response
@dsturnbull dsturnbull added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudformation Related to AWS CloudFormation label Nov 26, 2024
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 27, 2024

This should only be able to happen if the --no-rollback flag is ignored altogether. But it doesn't seem to be, right? Normally you are able to perform --no-rollback deployments?

Can you run npx cdk deploy --no-rollback -vvv when this happens again and paste the log?

@rix0rrr rix0rrr linked a pull request Nov 27, 2024 that will close this issue
Open
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 27, 2024

I was able to repro.

@ashishdhingra
Copy link
Contributor

PR #32309 pending merge.

@ashishdhingra ashishdhingra added p1 effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. p1 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: CLI warns about missing --no-rollback flag that is present aws/aws-cdk
3 participants
@dsturnbull @rix0rrr @ashishdhingra