Ignore unknown metadata and shape keys (#3095)

aws · Aug 29, 2024 · a0c854d · a0c854d
1 parent f187dd2
commit a0c854d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator.rb b/build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator.rb
@@ -103,4 +103,13 @@ module AwsSdkCodeGenerator
 # WARNING ABOUT GENERATED CODE
   WARNING_TXT
 
+  @warnings = []
+
+  class << self
+    attr_reader :warnings
+    def warn(service, type, message)
+      Kernel.warn(message)
+      @warnings << { service: service, type: type, message: message }
+    end
+  end
 end
diff --git a/build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/client_api_module.rb b/build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/client_api_module.rb
@@ -192,7 +192,11 @@ def metadata
               value: @service.api['metadata'][key].inspect
             }
           elsif METADATA_KEYS[key].nil?
-            raise "unhandled metadata key #{key.inspect}"
+            AwsSdkCodeGenerator.warn(
+              @service.service_id,
+              :invalid_key,
+              "unhandled metadata key `#{key}`"
+            )
           end
         end
         metadata
@@ -317,7 +321,11 @@ def shape_constructor_args(shape_name, shape)
 
             args << "#{key}: #{value.inspect}"
           elsif SHAPE_KEYS[key].nil?
-            raise "unhandled shape key #{key.inspect}"
+            AwsSdkCodeGenerator.warn(
+              @service.service_id,
+              :invalid_key,
+              "unhandled shape key `#{key}` on `#{shape_name}`"
+            )
           end
         end
         args.join(', ')