Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build info for CAPX #1313
Add build info for CAPX #1313
Changes from 6 commits
8f1ad93
f360b92
c98fad5
684f814
284ec92
dbefb89
24c103e
7d50f86
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like pointing to the go.mod as the source of truth for golang versions. Is there a better file in the CAPX repo, maybe the release job or makefile or dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really (we have github workflows which also specify the same value); can you elaborate on why we don't like go.mod specifying the version of Go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is because, the
go
directive in a go.mod file represents the minimum Go version that's required to compile that source code. For example, if your code uses generics, both your Go mod version and actual Go compile toolchain must be 1.18 because generics was added only in 1.18. But if there's nothing specific to 1.18 in the code, the go mod may contain 1.17 and still be compiled with 1.18 or anything above it. The ideal version for build-tooling should be, as Jackson stated above, the one you use in Makefile/Dockerfile/goreleaser.yml for go build