Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PassSigner singleton #10

Open
aydenp opened this issue Nov 25, 2021 · 0 comments
Open

Remove PassSigner singleton #10

aydenp opened this issue Nov 25, 2021 · 0 comments
Labels
api breaking Will result in an API change that breaks existing uses enhancement New feature or request good first issue Good for newcomers
Milestone
v2.0

Comments

@aydenp
Copy link
Owner

aydenp commented Nov 25, 2021

There is no reason this needs to be a singleton. Ideally it should be owned by PassEncoder or entirely separate.
@aydenp aydenp added enhancement New feature or request good first issue Good for newcomers api breaking Will result in an API change that breaks existing uses labels Nov 25, 2021
@aydenp aydenp added this to the 2.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api breaking Will result in an API change that breaks existing uses enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@aydenp