Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry ingress restrictions #374

Open
durandom opened this issue Aug 16, 2023 · 4 comments
Open

telemetry ingress restrictions #374

durandom opened this issue Aug 16, 2023 · 4 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@durandom
Copy link
Member

durandom commented Aug 16, 2023

Influx will create the schema on the fly, i.e. the first time it sees a field, it will create the field with the data type.
This opens up our pipeline to spam and schema corruption.
Let's be a bit more strict and clean up our telegraf.conf

  • only allow the crewchief topic (remove crewchief_v2 and racing)
  • either don't use the mqtt_consumer.json_v2.object parsing and be specific about the fields
  • or keep using it and restrict the fields

documentation is at

@durandom
Copy link
Member Author

maybe we have to upgrade our telegraf from 1.22 to 1.27

@durandom
Copy link
Member Author

durandom commented Aug 16, 2023

{
  "time": 1692204578177,
  "telemetry": {
    "Clutch": 0,
    "Brake": 0,
    "Throttle": 0.9999999,
    "Handbrake": 0,
    "SteeringAngle": 0.000227941709,
    "Rpms": 5677.957,
    "Gear": 3,
    "SpeedMs": 42.3292656,
    "DistanceRoundTrack": 2140.64087,
    "WorldPosition_x": 489.178741,
    "WorldPosition_y": 6.152093,
    "WorldPosition_z": 11.3597507,
    "CurrentLap": 5,
    "CurrentLapTime": 31.9163818,
    "LapTimePrevious": 73.70654,
    "CurrentLapIsValid": true,
    "PreviousLapWasValid": false,
    "CarClass": "GT3"
  }
}

and https://gitlab.com/mr_belowski/CrewChiefV4/-/blob/master/CrewChiefV4/mqtt_telemetry.json

@goern
Copy link
Member

goern commented Aug 17, 2023

/kind feature
/assign goern

@op1st-prow op1st-prow bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 17, 2023
@goern
Copy link
Member

goern commented Aug 17, 2023

maybe we have to upgrade our telegraf from 1.22 to 1.27

implemented by #381

goern added a commit to goern/racing that referenced this issue Aug 17, 2023
goern added a commit to goern/racing that referenced this issue Aug 17, 2023
@goern goern mentioned this issue Aug 17, 2023
@goern goern added hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants