Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the rfc to move targets top level in the readme? #18

Closed
hzoo opened this issue May 26, 2020 · 1 comment · Fixed by #116
Closed

Mention the rfc to move targets top level in the readme? #18

hzoo opened this issue May 26, 2020 · 1 comment · Fixed by #116

Comments

@hzoo
Copy link
Member

hzoo commented May 26, 2020

Using this makes it clear we don't want to have different sets of target options babel/rfcs#2

{
  "presets": [
    ["@babel/preset-env", {
      "targets": ">1%, not ie 11"
    }]
  ],
"plugins": [
    [
      "babel-plugin-polyfill-corejs3",
      {
        "method": "usage-global",
        "targets": {
          "edge": 16
        }
      }
    ]
  ]
}
@agilgur5
Copy link
Contributor

agilgur5 commented Mar 1, 2022

I believe this was at least partially completed by 1694f0c , which added a link to the RFC in the Migration docs (which are mentioned in the README).

But in any case, the RFC has been implemented now and 1091fa4 changed the examples to use top-level targets, so I think this can almost certainly be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants