Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedules do not re-build when an adunit's size is modified #19

Open
solocommand opened this issue May 15, 2019 · 1 comment
Open

Schedules do not re-build when an adunit's size is modified #19

solocommand opened this issue May 15, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@solocommand
Copy link
Member

For reference, see JIRA CS-1944.

When line items/ads have been inserted with multiple sized creatives (600x100 and 300x250), and an ad unit targeted by those line items has it's sizes modified between the two, the schedules are not rebuilt. This means that the existing 300x250 ads are still scheduled to the adunit, even though they are now invalid.

A quick fix for this would be to re-save all line items targeting the ad unit (directly or indirectly), but a better one might be to abstract the schedule generation logic and run it in both places (line item save and adunit save).

@solocommand solocommand added the bug Something isn't working label May 15, 2019
@CaitlynKnudsvig
Copy link

Thanks Josh!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants