-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search schema #58
Search schema #58
Conversation
export default Ember.Controller.extend({ | ||
schemaName: '', | ||
schemaContent: '' | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This holds the temporary values of the new schema until they are ready to be sent to the server.
Tested, looks great overall. (Btw, fantastic job integrating Couple of feedback items:
|
@dmitrizagidulin Thank you for the excellent feedback. All the recommended changes have been incorporated. Points 5 and 6 were related, and originally I did the alert as I didn't know what to do with a schema that wasn't associated with an index (since that is how we are creating the list), but thinking about it after your feedback I realized the obvious fix of just creating one in the route if the cluster doesn't currently have that schema. So thanks, its a much cleaner flow now. |
Brilliant! Thanks, Paul! Looks great now, +1 here. One other minor question - there's some kind of indentation on the first line of the schema xml, in view mode. (Doesn't seem to be there in edit mode). Like:
Intended, or, worth fixing? |
Yeah, I noticed the indenting too, it is something to do with |
01821c3
to
e977147
Compare
Fixes issue #20