From 3a0900cbbc3f425e3e16ca8fd3e86de627b63489 Mon Sep 17 00:00:00 2001
From: Jakob Schnitzer <mail@jakobschnitzer.de>
Date: Sat, 26 Oct 2024 12:06:42 +0200
Subject: [PATCH] chore: use empty instead of self-closing tags

will be a warning in Svelte 5
---
 frontend/src/charts/Chart.svelte                      | 4 ++--
 frontend/src/charts/ChartLegend.svelte                | 2 +-
 frontend/src/editor/DocumentPreviewEditor.svelte      | 2 +-
 frontend/src/editor/SliceEditor.svelte                | 4 ++--
 frontend/src/entry-forms/Note.svelte                  | 2 +-
 frontend/src/modals/AddEntry.svelte                   | 2 +-
 frontend/src/modals/ModalBase.svelte                  | 2 +-
 frontend/src/reports/documents/DocumentPreview.svelte | 4 ++--
 frontend/src/reports/editor/Editor.svelte             | 2 +-
 frontend/src/reports/errors/Errors.svelte             | 4 ++--
 frontend/src/reports/import/Extract.svelte            | 4 ++--
 frontend/src/reports/query/QueryBox.svelte            | 2 +-
 frontend/src/reports/query/QueryEditor.svelte         | 2 +-
 frontend/src/reports/query/ReadonlyQueryEditor.svelte | 2 +-
 frontend/src/sidebar/AccountIndicator.svelte          | 6 +++---
 frontend/src/sidebar/FilterForm.svelte                | 2 +-
 frontend/src/sidebar/Header.svelte                    | 2 +-
 17 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/frontend/src/charts/Chart.svelte b/frontend/src/charts/Chart.svelte
index 59493cd7e..a49bd5036 100644
--- a/frontend/src/charts/Chart.svelte
+++ b/frontend/src/charts/Chart.svelte
@@ -42,7 +42,7 @@
         active={treemapCurrency}
       />
     {/if}
-    <span class="spacer" />
+    <span class="spacer"></span>
     {#if chart.type === "hierarchy"}
       <ModeSwitch store={hierarchyChartMode} />
     {:else if chart.type === "linechart"}
@@ -50,7 +50,7 @@
     {:else if chart.type === "barchart" && chart.hasStackedData}
       <ModeSwitch store={barChartMode} />
     {/if}
-  {:else}<span class="spacer" />{/if}
+  {:else}<span class="spacer"></span>{/if}
   <slot />
   <button
     type="button"
diff --git a/frontend/src/charts/ChartLegend.svelte b/frontend/src/charts/ChartLegend.svelte
index ddc846935..70b570ddd 100644
--- a/frontend/src/charts/ChartLegend.svelte
+++ b/frontend/src/charts/ChartLegend.svelte
@@ -24,7 +24,7 @@
       }}
       class:inactive={active ? item !== $active : $toggled?.includes(item)}
     >
-      <i style="background-color: {color ?? '#bbb'}" />
+      <i style="background-color: {color ?? '#bbb'}"></i>
       <span>{item}</span>
     </button>
   {/each}
diff --git a/frontend/src/editor/DocumentPreviewEditor.svelte b/frontend/src/editor/DocumentPreviewEditor.svelte
index 39e69b876..c0a007497 100644
--- a/frontend/src/editor/DocumentPreviewEditor.svelte
+++ b/frontend/src/editor/DocumentPreviewEditor.svelte
@@ -28,7 +28,7 @@
   }
 </script>
 
-<div use:renderEditor />
+<div use:renderEditor></div>
 
 <style>
   div {
diff --git a/frontend/src/editor/SliceEditor.svelte b/frontend/src/editor/SliceEditor.svelte
index 31e8a32f8..2c0669c73 100644
--- a/frontend/src/editor/SliceEditor.svelte
+++ b/frontend/src/editor/SliceEditor.svelte
@@ -82,9 +82,9 @@
 </script>
 
 <form on:submit|preventDefault={save}>
-  <div class="editor" use:renderEditor />
+  <div class="editor" use:renderEditor></div>
   <div class="flex-row">
-    <span class="spacer" />
+    <span class="spacer"></span>
     <label>
       <input type="checkbox" bind:checked={$reloadAfterSavingEntrySlice} />
       <span>{_("reload")}</span>
diff --git a/frontend/src/entry-forms/Note.svelte b/frontend/src/entry-forms/Note.svelte
index dd18c94a0..bef2f5e9d 100644
--- a/frontend/src/entry-forms/Note.svelte
+++ b/frontend/src/entry-forms/Note.svelte
@@ -19,7 +19,7 @@
     />
     <AddMetadataButton bind:meta={entry.meta} />
   </div>
-  <textarea name="comment" rows={2} bind:value={entry.comment} />
+  <textarea name="comment" rows={2} bind:value={entry.comment}></textarea>
   <EntryMetadata bind:meta={entry.meta} />
 </div>
 
diff --git a/frontend/src/modals/AddEntry.svelte b/frontend/src/modals/AddEntry.svelte
index cecd0aaf8..25ad26636 100644
--- a/frontend/src/modals/AddEntry.svelte
+++ b/frontend/src/modals/AddEntry.svelte
@@ -54,7 +54,7 @@
     </h3>
     <Entry bind:entry />
     <div class="flex-row">
-      <span class="spacer" />
+      <span class="spacer"></span>
       <label>
         <input type="checkbox" bind:checked={$addEntryContinue} />
         <span>{_("continue")}</span>
diff --git a/frontend/src/modals/ModalBase.svelte b/frontend/src/modals/ModalBase.svelte
index 96ddacb86..9a9272780 100644
--- a/frontend/src/modals/ModalBase.svelte
+++ b/frontend/src/modals/ModalBase.svelte
@@ -53,7 +53,7 @@
 
 {#if shown}
   <div class="overlay">
-    <div class="background" on:click={closeHandler} aria-hidden="true" />
+    <div class="background" on:click={closeHandler} aria-hidden="true"></div>
     <div class="content" use:handleFocus role="dialog" aria-modal="true">
       <slot />
       <button type="button" class="muted close" on:click={closeHandler}
diff --git a/frontend/src/reports/documents/DocumentPreview.svelte b/frontend/src/reports/documents/DocumentPreview.svelte
index fc942b4ed..71052d4ad 100644
--- a/frontend/src/reports/documents/DocumentPreview.svelte
+++ b/frontend/src/reports/documents/DocumentPreview.svelte
@@ -30,13 +30,13 @@
 </script>
 
 {#if extension === "pdf"}
-  <object title={filename} data={url} />
+  <object title={filename} data={url}></object>
 {:else if plainTextExtensions.includes(extension)}
   <DocumentPreviewEditor {url} />
 {:else if imageExtensions.includes(extension)}
   <img src={url} alt={filename} />
 {:else if ["html", "htm"].includes(extension)}
-  <iframe src={url} title={filename} sandbox="" />
+  <iframe src={url} title={filename} sandbox=""></iframe>
 {:else}
   Preview for file `{filename}` with file type `{extension}` is not implemented
 {/if}
diff --git a/frontend/src/reports/editor/Editor.svelte b/frontend/src/reports/editor/Editor.svelte
index de3169fb7..0ed60447a 100644
--- a/frontend/src/reports/editor/Editor.svelte
+++ b/frontend/src/reports/editor/Editor.svelte
@@ -131,7 +131,7 @@
   <EditorMenu {file_path} {editor}>
     <SaveButton {changed} {saving} />
   </EditorMenu>
-  <div use:renderEditor />
+  <div use:renderEditor></div>
 </form>
 
 <style>
diff --git a/frontend/src/reports/errors/Errors.svelte b/frontend/src/reports/errors/Errors.svelte
index 5bde2fcfd..f1608a277 100644
--- a/frontend/src/reports/errors/Errors.svelte
+++ b/frontend/src/reports/errors/Errors.svelte
@@ -64,8 +64,8 @@
               <a class="source" href={url} {title}>{source.lineno}</a>
             </td>
           {:else}
-            <td />
-            <td class="num" />
+            <td></td>
+            <td class="num"></td>
           {/if}
           <!-- eslint-disable-next-line svelte/no-at-html-tags -->
           <td class="pre">{@html addAccountLinks(message)}</td>
diff --git a/frontend/src/reports/import/Extract.svelte b/frontend/src/reports/import/Extract.svelte
index 61d7bb82a..b7559cac1 100644
--- a/frontend/src/reports/import/Extract.svelte
+++ b/frontend/src/reports/import/Extract.svelte
@@ -51,7 +51,7 @@
           ({entries.length - duplicates}
           to import):
         </h3>
-        <span class="spacer" />
+        <span class="spacer"></span>
         <label class="button muted">
           <input
             type="checkbox"
@@ -79,7 +79,7 @@
             {_("Previous")}
           </button>
         {/if}
-        <span class="spacer" />
+        <span class="spacer"></span>
         {#if currentIndex < entries.length - 1}
           <button type="submit">{_("Next")}</button>
           <button
diff --git a/frontend/src/reports/query/QueryBox.svelte b/frontend/src/reports/query/QueryBox.svelte
index 5ce616d07..8c4bf00fa 100644
--- a/frontend/src/reports/query/QueryBox.svelte
+++ b/frontend/src/reports/query/QueryBox.svelte
@@ -36,7 +36,7 @@
 <details bind:open>
   <summary class:inactive on:click={inactive ? onselect : null}>
     <ReadonlyQueryEditor value={query} error={result?.is_err} />
-    <span class="spacer" />
+    <span class="spacer"></span>
     {#if result && result.is_ok && result.value.t === "table"}
       <QueryLinks {query} />
     {/if}
diff --git a/frontend/src/reports/query/QueryEditor.svelte b/frontend/src/reports/query/QueryEditor.svelte
index b85b523d2..86127a99a 100644
--- a/frontend/src/reports/query/QueryEditor.svelte
+++ b/frontend/src/reports/query/QueryEditor.svelte
@@ -22,7 +22,7 @@
 </script>
 
 <form on:submit|preventDefault={submit}>
-  <div use:renderEditor />
+  <div use:renderEditor></div>
   <button type="submit" use:keyboardShortcut={"Control+Enter"}>
     {_("Submit")}
   </button>
diff --git a/frontend/src/reports/query/ReadonlyQueryEditor.svelte b/frontend/src/reports/query/ReadonlyQueryEditor.svelte
index 6c4b0242d..d7a012be0 100644
--- a/frontend/src/reports/query/ReadonlyQueryEditor.svelte
+++ b/frontend/src/reports/query/ReadonlyQueryEditor.svelte
@@ -7,7 +7,7 @@
   const { renderEditor } = initReadonlyQueryEditor(value);
 </script>
 
-<pre class:error use:renderEditor />
+<pre class:error use:renderEditor></pre>
 
 <style>
   .error {
diff --git a/frontend/src/sidebar/AccountIndicator.svelte b/frontend/src/sidebar/AccountIndicator.svelte
index 6eae04165..9a46992ef 100644
--- a/frontend/src/sidebar/AccountIndicator.svelte
+++ b/frontend/src/sidebar/AccountIndicator.svelte
@@ -24,7 +24,7 @@
       class="status-indicator status-green"
       class:small
       title="The last entry is a passing balance check."
-    />
+    ></span>
   {:else}
     <copyable-text
       class="status-indicator status-{status}"
@@ -39,14 +39,14 @@ Click to copy the balance directives to the clipboard:
 
 ${balance}`}
       data-clipboard-text={balance}
-    />
+    ></copyable-text>
   {/if}
   {#if last_account_activity > $fava_options.uptodate_indicator_grey_lookback_days}
     <span
       class="status-indicator status-gray"
       class:small
       title="This account has not been updated in a while. ({last_account_activity} days ago)"
-    />
+    ></span>
   {/if}
 {/if}
 
diff --git a/frontend/src/sidebar/FilterForm.svelte b/frontend/src/sidebar/FilterForm.svelte
index c3c901459..3bdb9554a 100644
--- a/frontend/src/sidebar/FilterForm.svelte
+++ b/frontend/src/sidebar/FilterForm.svelte
@@ -92,7 +92,7 @@
     on:select={submit}
     on:enter={submit}
   />
-  <button type="submit" />
+  <button type="submit"></button>
 </form>
 
 <style>
diff --git a/frontend/src/sidebar/Header.svelte b/frontend/src/sidebar/Header.svelte
index 3ee8209bc..9a93a2a2c 100644
--- a/frontend/src/sidebar/Header.svelte
+++ b/frontend/src/sidebar/Header.svelte
@@ -36,7 +36,7 @@
   >
     &#8635;
   </button>
-  <span class="spacer" />
+  <span class="spacer"></span>
   <FilterForm />
 </header>