Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove array attributes #24

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Remove array attributes #24

merged 2 commits into from
Jun 15, 2020

Conversation

govynnus
Copy link
Member

No description provided.

@govynnus
Changed attributes that were arrays to strings
fe13bdd 
As discussed in issues #7 and #23, make all non-numerical fields strings rather
than arrays, and plan to support multi-valued fields in a future extension.

#7
#23
@govynnus
Fixed grammatical error
d877e55
@govynnus
Copy link
Member Author

govynnus commented Jun 15, 2020 •
edited
Loading

As we discussed in #23 I changed attributes that used to be arrays to strings, and added a note about supporting multi-valued attributes in an extension.

@sampsyo
Copy link
Member

sampsyo commented Jun 15, 2020

Perfect; thanks!!

@sampsyo sampsyo merged commit 183da5f into beetbox:master Jun 15, 2020
@govynnus govynnus deleted the remove-array-attributes branch June 28, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@govynnus @sampsyo