-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hybrid SACD importing #5149
Conversation
Can I get any feedback on this PR? |
uhoh, I tried to get fancy with git :( let me fix that |
016cc6d
to
1faf9d3
Compare
Okay, I think I successfully got git fancy. Would love some feedback on this PR! |
Hey, before this slips off the front page of PRs, what do we have to do to implement this fix? |
Looks good to me. I'd love to see this merged, as I have this exact problem. It also seems reasonable in general to consider the medium number even for other media. |
It has come in handy for me when I want to import just one disk of a release that has both cds and bluerays or something. |
Here is an example of a non-SACD release which can't be properly imported right now: https://musicbrainz.org/release/ea92a194-2d60-35c7-9d56-0e1dba20cd45 |
docs/changelog.rst
Outdated
@@ -425,6 +425,9 @@ Bug fixes: | |||
`requests` timeout. | |||
* Fix cover art resizing logic to support multiple steps of resizing | |||
:bug:`5151` | |||
* Fix bug where matcher doesn't consider medium number when importing making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing - you probably want to rebase off the most recent master
version and move your changelog note to the top, under the Unreleased section!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, rebased and squashed. Changelog note moved to the top unreleased section.
3b975cc
to
32e9e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This looks good, thanks!
Description
Fixes #5148.
When importing, the code that matches tracks does not consider the medium number. This causes problems on Hybrid SACDs (and other releases) where the artists, track numbers, titles, and lengths are the same on both layers.
I added a distance penalty for mismatching medium numbers.
Before:
Note that all tracks tagged with disc 1 get moved to disc 2 and vice versa.
After:
Yay!
To Do
Documentation. (If you've added a new command-line flag, for example, find the appropriate page underdocs/
to describe it.)docs/changelog.rst
to the bottom of one of the lists near the top of the document.)