-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Create new release on musicbrainz" feature #5300
Open
jonaswinkler
wants to merge
10
commits into
beetbox:master
Choose a base branch
from
jonaswinkler:feature/mbsubmit-create-release
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3d23248
implement mbsubmit create release on musicbrainz
jonaswinkler da35f6e
fix test case
jonaswinkler 28a6e64
fix linter warnings
jonaswinkler 096356e
update lockfile
jonaswinkler 5fa8fbc
use flask instead of python HTTPServer, review comments
jonaswinkler 2b62e72
update port choosing logic
jonaswinkler 3fb6c67
implement defaults for common fields
jonaswinkler 20b1935
fix complete_add template
jonaswinkler 420178a
lint fixes
jonaswinkler 3800b71
update documentation
jonaswinkler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!doctype html> | ||
<meta charset="UTF-8"> | ||
<html> | ||
<body> | ||
<form action="https://musicbrainz.org/release/add" method="post" style="display: none"> | ||
{% for k,v in task.formdata.items() %} | ||
<input type="hidden" name="{{ k }}" value="{{ v }}"> | ||
{% endfor %} | ||
<input type="submit"> | ||
</form> | ||
<script>document.forms[0].submit()</script> | ||
</body> |
6 changes: 6 additions & 0 deletions
6
beetsplug/mbsubmit/templates/create_release_complete_add.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<!doctype html> | ||
<meta charset="UTF-8"> | ||
<html> | ||
<body> | ||
<p>Release <a href="https://www.musicbrainz.org/release/{{ task.result_release_mbid }}">{{ task.result_release_mbid }}</a> added. You can close this browser window now and return to beets.</p> | ||
</body> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're now recommending that people install and manage beets with poetry, so if you wouldn't mind changing this, it should be
poetry install beets --extras mbsubmit
.