Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediafile to 0.13.0 #5494

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

jackwilsdon
Copy link
Member

Description

Fixes #5420.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

Copy link

github-actions bot commented Nov 3, 2024

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@@ -992,7 +992,7 @@ def run(self, *args, **kwargs):
super().run(*args, **kwargs)

IMAGEHEADER = {
"image/jpeg": b"\x00" * 6 + b"JFIF",
"image/jpeg": b"\xff\xd8\xff" + b"\x00" * 3 + b"JFIF",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I want to know how did you discover that this had to updated 😆

@snejus
Copy link
Member

snejus commented Nov 10, 2024

You can ignore the coverage action failure - it still needs resolving 🙁

@snejus snejus merged commit 6a7efdf into beetbox:master Nov 15, 2024
10 of 11 checks passed
@jackwilsdon jackwilsdon deleted the update-mediafile branch November 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13 support
2 participants