Merge pull request #2478 from proneon267/iOS_divider

Implemented Divider widget on iOS

changes/2478.feature.rst

@@ -0,0 +1 @@
+The Divider widget was implemented on iOS.

docs/reference/api/widgets/divider.rst

@@ -29,9 +29,11 @@ A separator used to visually distinguish two sections of content in a layout.
        :align: center
        :width: 300px
 
-  .. group-tab:: iOS |no|
+  .. group-tab:: iOS
 
-    Not supported
+    .. figure:: /reference/images/divider-iOS.png
+       :align: center
+       :width: 300px
 
   .. group-tab:: Web |beta|
 

docs/reference/data/widgets_by_platform.csv

@@ -8,7 +8,7 @@ Button,General Widget,:class:`~toga.Button`,Basic clickable Button,|y|,|y|,|y|,|
 Canvas,General Widget,:class:`~toga.Canvas`,A drawing area for 2D vector graphics.,|y|,|y|,|y|,|y|,|y|,,
 DateInput,General Widget,:class:`~toga.DateInput`,A widget to select a calendar date,,,|y|,,|y|,,
 DetailedList,General Widget,:class:`~toga.DetailedList`,"An ordered list of content where each item has an icon, a main heading, and a line of supplementary text.",|y|,|y|,|b|,|y|,|y|,,
-Divider,General Widget,:class:`~toga.Divider`,A horizontal or vertical line,|y|,|y|,|y|,,|y|,|b|,
+Divider,General Widget,:class:`~toga.Divider`,A horizontal or vertical line,|y|,|y|,|y|,|y|,|y|,|b|,
 ImageView,General Widget,:class:`~toga.ImageView`,A widget that displays an image,|y|,|y|,|y|,|y|,|y|,,
 Label,General Widget,:class:`~toga.Label`,Text label,|y|,|y|,|y|,|y|,|y|,|b|,|b|
 MapView,General Widget,:class:`~toga.MapView`,A zoomable map that can be annotated with location pins,|y|,|y|,|y|,|y|,|y|,,

iOS/src/toga_iOS/factory.py

@@ -16,6 +16,7 @@
 from .widgets.button import Button
 from .widgets.canvas import Canvas
 from .widgets.detailedlist import DetailedList
+from .widgets.divider import Divider
 from .widgets.imageview import ImageView
 from .widgets.label import Label
 from .widgets.mapview import MapView
@@ -62,6 +63,7 @@ def not_implemented(feature):
     "Button",
     "Canvas",
     "DetailedList",
+    "Divider",
     "ImageView",
     "Label",
     "MapView",

iOS/src/toga_iOS/widgets/divider.py

@@ -0,0 +1,41 @@
+from travertino.size import at_least
+
+from toga_iOS.libs import UIColor, UIView
+from toga_iOS.widgets.base import Widget
+
+
+class Divider(Widget):
+    def create(self):
+        self.native = UIView.alloc().init()
+        self.native.interface = self.interface
+        self.native.impl = self
+
+        # Background color needs to be set or else divider will not be visible.
+        self.system_gray_color = UIColor.systemGrayColor()
+        self.native.backgroundColor = self.system_gray_color
+
+        # Add the layout constraints
+        self.add_constraints()
+
+        # Set the initial direction
+        self._direction = self.interface.HORIZONTAL
+
+    def set_background_color(self, value):
+        # Do nothing, since background color of Divider shouldn't be changed.
+        pass
+
+    def rehint(self):
+        content_size = self.native.intrinsicContentSize()
+
+        if self._direction == self.interface.VERTICAL:
+            self.interface.intrinsic.width = 1
+            self.interface.intrinsic.height = at_least(content_size.height)
+        else:
+            self.interface.intrinsic.width = at_least(content_size.width)
+            self.interface.intrinsic.height = 1
+
+    def get_direction(self):
+        return self._direction
+
+    def set_direction(self, value):
+        self._direction = value

iOS/tests_backend/widgets/divider.py

@@ -0,0 +1,7 @@
+from toga_iOS.libs import UIView
+
+from .base import SimpleProbe
+
+
+class DividerProbe(SimpleProbe):
+    native_class = UIView

testbed/tests/widgets/test_divider.py

@@ -4,7 +4,6 @@
 from toga.constants import Direction
 from toga.style.pack import COLUMN, ROW
 
-from ..conftest import skip_on_platforms
 from .properties import (  # noqa: F401
     test_enable_noop,
     test_focus_noop,
@@ -13,7 +12,6 @@
 
 @pytest.fixture
 async def widget():
-    skip_on_platforms("iOS")
     return toga.Divider()