Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all background color tests on all widgets #3015

Open
proneon267 opened this issue Dec 4, 2024 · 0 comments
Open

Enable all background color tests on all widgets #3015

proneon267 opened this issue Dec 4, 2024 · 0 comments
Labels
enhancement New features, or improvements to existing features.

Comments

@proneon267
Copy link
Contributor

proneon267 commented Dec 4, 2024

What is the problem or limitation you are having?

Related PRs: #3009, #2484

Context:

Currently all the 3 background color tests on the testbed cannot be enabled for all widgets, since there are problems associated with the widget background color on some platforms like on Android and Winforms. If we enable all 3 background color tests on every widget, then the testbed would pass on iOS, but would fail on other platforms. At the same time, we cannot correct their behavior to make them pass the tests as fixes for those platforms exist on separate PRs.
For example, If we enable all the 3 tests: test_background_color, test_background_color_reset, test_background_transparent on the Box widget then the tests would pass on iOS, but would fail on Winforms, since the fix for winforms exists on a separate PR.

Since behavioral changes need tests that confirms their behavior. So, to prevent a deadlock situation that would prevent this PR from being merged, I have created this issue to keep track of the widgets on which background color tests are not enabled. Since all 3 tests are enabled on most widgets so the list would be small. Afterwards, when all 3 dependent PRs are merged, we can enable all the 3 background color tests on all the widgets.

Current status:

test_background_color test_background_color_reset test_background_color_transparency
ActivityIndicator
Box
Button
Canvas
DateInput
DetailedList
Divider
ImageView
Label
MapView
MultilineTextInput
NumberInput
OptionContainer
PasswordInput
ProgressBar
ScrollContainer
Selection
Slider
SplitContainer
Switch
Table
TextInput
TimeInput
Tree
WebView

Additional context

Note: There are some widgets on which background color setting might not be relevant like on MapView or WebView. So, I will add more context for those widgets later.

@proneon267 proneon267 added the enhancement New features, or improvements to existing features. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

1 participant