Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the ActivityIndicator tests to also check for visibility when… #2838

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated the ActivityIndicator tests to also check for visibility when… #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2990c6a
Updated the ActivityIndicator tests to also check for visibility when…
maranas Sep 13, 2024
0abadb2
Added changes rst file for test updates
maranas Sep 13, 2024
f2798ea
Removed duplicate assert
maranas Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2838.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The ActivityIndicator tests now check for the correct visibility behavior when started and stopped.
4 changes: 4 additions & 0 deletions cocoa/tests_backend/widgets/activityindicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@

class ActivityIndicatorProbe(SimpleProbe):
native_class = NSProgressIndicator

@property
def is_hidden(self):
Copy link
Member

@freakboy3742 freakboy3742 Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth being explicit that we're talking about the spinner visibility here. Depending on the implementation, it would be possible to have a widget that is "visible" in the sense of Toga's drawing instructions, but that that displays no content because the spinner is hidden. iOS got caught on this because spinner visibility and widget visibility are treated as the same thing; but that's no necessarily the same.

There's already a probe for evaluating visibility; spinner visibility isn't necessarily the same thing.

(edit) not sure what happened... this got submitted before I finished writing the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @freakboy3742 ! I will have a look deeper into this - it looks like it is possible to do in iOS and macOS but I still need to figure out for the Linux and Windows implementations how it would be done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winforms doesn't have an ActivityIndicator, so the solution there will be easy :-)

As for Linux - if we can verify that the GTK widget behaves as expected (i.e., hidden and running are different properties, and a stopped indicator is defined as not visible, but not hidden), then it might be sufficient to just check the active property.

return self.native.isHidden()
4 changes: 4 additions & 0 deletions gtk/tests_backend/widgets/activityindicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@

class ActivityIndicatorProbe(SimpleProbe):
native_class = Gtk.Spinner

@property
def is_hidden(self):
return not self.native.get_visible()
4 changes: 4 additions & 0 deletions iOS/tests_backend/widgets/activityindicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@

class ActivityIndicatorProbe(SimpleProbe):
native_class = UIActivityIndicatorView

@property
def is_hidden(self):
return self.native.isHidden()
2 changes: 2 additions & 0 deletions testbed/tests/widgets/test_activityindicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ async def test_start_stop(widget, probe):

# Widget should now be started
assert widget.is_running
assert not probe.is_hidden

widget.stop()
await probe.redraw("Activity Indicator should be stopped")

# Widget should now be stopped
assert not widget.is_running
assert probe.is_hidden


async def test_fixed_square_widget_size(widget, probe):
Expand Down
Loading