Fix issue with parallel derivatives #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows to export BOUT_TOP for all projects
In case of fci, we need to apply parallel boundaries as well.
The for loop took a copy, rather then the field itself.
allows to compile with cmake
This reverts commit fc3fe5d.
DC is inherently unsuitable, as it depends on the free parameter of the grid generation, namely all parallel slices can be abitrarily rotated in poloidal direction, thus at most 1D averaging could be used.
Works, no reason to average
* Always use floor'ed fields * some additional calls to communicate + parallel BCs
Can be done with boutcore in post processing
This prevents overwriting the boundary conditions of Te etc for the
kappa_{i,e}par, thus probably more correct then the previous version.
Unify forward + backward, only difference is the sign in a few cases.
|
Are sheath boundary conditions not needed on all parallel boundaries? Is this to prevent issues in the inner (core) boundary? |
|
For the W7X mesh the outer boundaries end on the wall, while the inner are towards the hot plasma of the core. Of course they could be overwritten, but I think it makes sense to directly only apply these BCs to the field lines ending up on targets. |
Add basic CI workflow
* Fix typo (parallel_sheath**s**) * Suggestions from v5-auto-updater
* Use correct terms for laplacian newsolver * Cleanup input files
simple low order
Probably not correct. We can implement something correct later - it should not be of major important.
If we apply standard boundaries, we probably also want FCI ones
Cleanup + boundary conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.