Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing namespace from boost::asio to anything else #45

Open
solvingj opened this issue Aug 26, 2017 · 2 comments
Open

Consider changing namespace from boost::asio to anything else #45

solvingj opened this issue Aug 26, 2017 · 2 comments

Comments

@solvingj
Copy link

Since the project is not actually part of ASIO, consider moving things to a separate namespace.

@berkus
Copy link
Owner

berkus commented Aug 29, 2017

I didn't invent this - this was done by Boris long time ago, I guess he was aiming to make it part of asio eventually (but why?).

Any suggestions what the proper namespace would be? boost::filesystem? :)

@solvingj
Copy link
Author

I'm new to the community so not likely to be the best one to decide. Ask the folks in slack for opinions i think. However, personally I would never put anything in boost namespace unless it would be proposed to become part of boost, which this never will. It depends on boost, that's all. I would set the namespace to simply be dir_monitor, although I prefer the namespacing of java and dotnet where it's org.lib to avoid clashing later. could use berkus.dir_monitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants