From 5b5d74a2677c281d12cd69825d2e252842786667 Mon Sep 17 00:00:00 2001 From: Joel Challis Date: Thu, 10 Dec 2020 19:02:41 +0000 Subject: [PATCH] Fix warning logic when running 'qmk format -a' (#11177) --- lib/python/qmk/cli/cformat.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/python/qmk/cli/cformat.py b/lib/python/qmk/cli/cformat.py index 6bcd15a1102a..5aab31843cc7 100644 --- a/lib/python/qmk/cli/cformat.py +++ b/lib/python/qmk/cli/cformat.py @@ -23,8 +23,6 @@ def cformat_run(files, all_files): if not files: cli.log.warn('No changes detected. Use "qmk cformat -a" to format all files') return False - if files and all_files: - cli.log.warning('Filenames passed with -a, only formatting: %s', ','.join(files)) subprocess.run(clang_format + [file for file in files], check=True) cli.log.info('Successfully formatted the C code.') @@ -48,6 +46,8 @@ def cformat(cli): # Find the list of files to format if cli.args.files: files.extend(normpath(file) for file in cli.args.files) + if cli.args.all_files: + cli.log.warning('Filenames passed with -a, only formatting: %s', ','.join(map(str, files))) # If -a is specified elif cli.args.all_files: all_files = c_source_files(core_dirs)