Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration to override locale #67

Open
fabioi opened this issue Nov 22, 2018 · 1 comment
Open

Allow configuration to override locale #67

fabioi opened this issue Nov 22, 2018 · 1 comment

Comments

@fabioi
Copy link

fabioi commented Nov 22, 2018

Hello, thank you for the great package, it is indeed very useful! :)

Wanted just to ask if it would be possibile to add the option in the config file to override the locale used by the package, since I am located in Italy and now to use the package I would need to translate all the strings to Italian, which I am not that interested. Since deployments scripts and code are usually written in english, I would actually prefer to have the messages in english.

Thank you in advance!

Fabio

@LaPelle
Copy link

LaPelle commented May 20, 2019

I agree, I've got a similar issue. I'm using locale in the format en_GB, en_US etc. My fallback locale is formatted the same way.

After installing and running the artisan command, the translation keys are displayed instead of the translations.

I've fixed this for now by publishing the translations and renaming /resources/lang/vendor/self-diagnosis/en to /resources/lang/vendor/self-diagnosis/en_GB, but I rather not publish the translation files and just use the default ones due to future updates.

A default locale setting in the config would fix this or maybe automaticity fallback to English if the app locale isn't found for the self-diagnose translations.

I think this is an addition to #8

mazedlx added a commit to mazedlx/laravel-self-diagnosis that referenced this issue Aug 8, 2019
Since the correct locale on macOS is `en_US.UTF-8` and not `en_US.utf8` the default config should take that into account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants