Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the book and/or add a workflow for doing so #677

Open
hecatia-elegua opened this issue Apr 23, 2023 · 2 comments · May be fixed by #742
Open

Update the book and/or add a workflow for doing so #677

hecatia-elegua opened this issue Apr 23, 2023 · 2 comments · May be fixed by #742

Comments

@hecatia-elegua
Copy link

I noticed ´fibonacci´ not being public in the github pages book, but that was fixed a few months ago:

criterion.rs/book/src/getting_started.md

Line 9 in 57c4d84

pub fn fibonacci(n: u64) -> u64 {

If anyone wants to pick this up, adding a github actions workflow for this will save some time.
something like this: example workflow
@kraktus
Copy link
Contributor

kraktus commented Nov 10, 2023

bump, just came across this too, the repo's book is updated to include version 0.5.1 but the online version is still stuck at 0.3: https://bheisler.github.io/criterion.rs/book/getting_started.html

@kraktus kraktus linked a pull request Nov 10, 2023 that will close this issue
Open
@kraktus
Copy link
Contributor

kraktus commented Nov 10, 2023

I've opened a PR, in the meantime if someone wants to see the up-to-date book, it's up here: https://kraktus.github.io/criterion.rs/criterion_rs.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Book: CD to Github page kraktus/criterion.rs
2 participants
@kraktus @hecatia-elegua