Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VolatileViews with Invalidate #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

VolatileViews with Invalidate #35

wants to merge 3 commits into from

Conversation

hanslovsky
Copy link
Contributor

This PR exposes the Invalidate interface of the volatile cache when wrapping a RandomAccessibleInterval with VolatileViews.wrapAsVolatile as discussed on gitter:

  1. Refactor VolatileViews.createVolatileCachedCellImg to VolatileViews.createVolatileCache to get access to cache
  2. Have VolatileViewData implement Invalidate<Long> to expose the volatile cache's Invalidate.
  • Delegate to invalidate that is passed in constructor
  • This could possibly be Invalidate<K>, but would add generic parameter
  1. Have VolatileRandomAccessibleIntervalView implement Invalidate<Long>
  • Makes it easy to check downstream, just check for rai instanceof Invalidate<?>
  • Could be useful for CachedCellImg as well for the same reason.

This should probably bye squashed into a single commit upon merge.

axtimwalde pushed a commit to axtimwalde/bigdataviewer-vistools that referenced this pull request Feb 6, 2024
@NicoKiaru
Merge pull request bigdataviewer#35 from haesleinhuepf/brightnessAdju…
addcfe3 
…ster

Fix bug in getSourceIndex() and rename brightnessAdjuster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanslovsky