Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans of further vCenter integration #339

Open
bb-Ricardo opened this issue Nov 22, 2024 · 7 comments
Open

Plans of further vCenter integration #339

bb-Ricardo opened this issue Nov 22, 2024 · 7 comments
Labels
discussion This issue is for discussion purposes.

Comments

@bb-Ricardo
Copy link

Hi,

I found your project as someone mentioned this project over at https://github.com/bb-Ricardo/netbox-sync

Great effort to integrate so many sources, a lot of work. I was wondering if you plan to sort of match the features netbox-sync provides? If yes, maybe I could support you and eventually retire netbox-sync. Seems silly to have two projects working on the same solution. Could provide the check_redfish resource as well.

What do you think?

@bl4ko
Copy link
Owner

bl4ko commented Nov 22, 2024

Hello,
thanks for reaching out. Netbox-sync was kinda an inspiration for this project. The main difference is that netbox-ssot was designed to run multiple sources in parallel to speed up the sync process. Thats why the go langugage (not python) was chosen for this project. However, this also introduces a trade-off—being outside the Python ecosystem of the NetBox stack may make it less approachable for Python-focused contributors.

Regarding the features of netbox-ssot, most of the currently implemented ones are very similar to the ones in netbox-sync (maybe only different naming convention), the difference is that netbox-ssot doesn't currently have as many features and so it is not as configurable as netbox-sync. This is because the project isn't as mature yet, and the extra features that are not implemented yet, didn't seem so critical to me. But they can for sure be added in future releases.

Regarding the check_redfish source. I implement additional sources, if I have access to them, or there can be some kind of mock API, so I can test the code. So by myself I can't add it, but if you are willing to contribute on this topic, I am very happy to help implementing it or adding you as a maintainer for this source on the project.

@bb-Ricardo
Copy link
Author

Hey,

Yes, reading through the source and the config vars it seems that netbox-sync had an influence on this project.

I'm aware of the serial approach in netbox-sync and being single threaded. Getting this right with the async framework seemed more trouble than worth it. Also some resources depend on each other and therefore it seemed a better to collect all the data first and then syncing only the differences.

Check redfish just exports json files and they are ingested one by one, read from a dedicated path: https://github.com/bb-Ricardo/netbox-sync/blob/main/module/sources/check_redfish/import_inventory.py

netbox-sync itself did not have many contributors and therefore I don't think it would be a big issue changing the programming language.

@bl4ko
Copy link
Owner

bl4ko commented Nov 25, 2024

Agree on the aysnc part, but the problem is that larger deployments with 10k+ objects, just work to slow with synchronous approach...

Thanks for the resources for the redfish. Since, I don't have redfish service deployed locally nor I can't test it, will you be willing to maintain this source? I can try creating starting template (code) for this source, from your python example, but I would need someone to test and maintain this?

@bb-Ricardo
Copy link
Author

Hi,

Yes, that would be great. I also started already on the structs and some parsing.

Still have to understand how the internal inventory is used.

On the other note: do you plan to add reading of tags from vCenter?

@bl4ko
Copy link
Owner

bl4ko commented Nov 26, 2024

Hi,

if you are have any questions regarding the implementation of inventory, I can help explain it you.

I will add readings of tags from vCenter, I will open separate issue for that...

@bl4ko bl4ko added the discussion This issue is for discussion purposes. label Nov 26, 2024
@bb-Ricardo
Copy link
Author

Would like me to open some issues regarding some topics of vCenter syncing. I don't want to just create a bag of work for you which then seems like an obligation.

@bl4ko
Copy link
Owner

bl4ko commented Nov 27, 2024

I’m always open to implementing new features, especially if I can test them on my setup. Regarding vCenter, I currently have multiple deployments I’m testing with, so feel free to open as many issues as needed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue is for discussion purposes.
Projects
None yet
Development

No branches or pull requests

2 participants