Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/hide passwords from logs #9174

Closed
JohannCR opened this issue Jan 2, 2024 · 6 comments
Closed

Remove/hide passwords from logs #9174

JohannCR opened this issue Jan 2, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@JohannCR
Copy link
Contributor

JohannCR commented Jan 2, 2024

Describe what you are trying to accomplish and why in non technical terms
Can we remove or hide the passwords and usernames from the logs ? Obvious security risk^^

Describe the solution you'd like
config option to obfuscate values in logs or something similar

Describe alternatives you've considered
no idea

Additional context
none

@JohannCR JohannCR added the enhancement New feature or request label Jan 2, 2024
@mabed-fr
Copy link

mabed-fr commented Jan 2, 2024

I use environment variables for the config, I would also like the logs to display them instead of the real identifiers.

@NickM-27
Copy link
Collaborator

NickM-27 commented Jan 2, 2024

What passwords do you see in logs? Frigate already obfuscates cameras user/pass

@JohannCR
Copy link
Contributor Author

JohannCR commented Jan 2, 2024

You're right in the frigate logs there are no camera passwords, but in the go2rtc logs there are... Do we need to take this up with AlexxIT ?

@NickM-27
Copy link
Collaborator

NickM-27 commented Jan 2, 2024

I would suggest making a request on the go2rtc repo that the go2rtc logs hide that information

@mabed-fr
Copy link

mabed-fr commented Jan 3, 2024

I also see in the API stats
/api/stats

@NickM-27
Copy link
Collaborator

NickM-27 commented Jan 3, 2024

fixed in #9189

I would suggest creating a new issue for frigate and provide specifics about where a user / pass is shown if any more are seen. Regarding go2rtc logs, there is an existing issue for that AlexxIT/go2rtc#238

@NickM-27 NickM-27 closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants