Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite error tabs when custodians is greater than quorum and quorum is 1 #15

Open
m4gpi opened this issue Sep 3, 2018 · 0 comments
Open
Labels
bug Something isn't working

Comments

@m4gpi
Copy link
Member

m4gpi commented Sep 3, 2018

Steps to reproduce

  • Open Patchbay
  • Open /dark-crystal
  • Set quorum to 1
  • Select 2 custodians
  • Complete the rest of form
  • Hit Perform Ritual

Expected Behaviour

It raises an neat custom error in the dropdown error box.

Actual Behaviour

Dark Crystal goes blank. Patchbay opens a new blank tab, which when you click on it (or /dark-crystal tab), infinitely opens another new one.

See terminal error:

Error: Threshold number of shares must be an integer between 2 and 2^bits-1 (255), inclusive.
    at Object.share (/home/kyphae/projects/patchbay/node_modules/secrets.js-grempe/secrets.js:786:23)
    at /home/kyphae/projects/patchbay/node_modules/scuttle-dark-crystal/share/async/share.js:41:28
    at server (/home/kyphae/projects/patchbay/node_modules/scuttle-inject/index.js:34:32)
    at watch (/home/kyphae/projects/patchbay/node_modules/mutant/once-true.js:8:7)
    at watch (/home/kyphae/projects/patchbay/node_modules/mutant/watch.js:7:5)
    at onceTrue (/home/kyphae/projects/patchbay/node_modules/mutant/once-true.js:4:17)
    at Object.share (/home/kyphae/projects/patchbay/node_modules/scuttle-inject/index.js:32:9)
    at performRitual (/home/kyphae/projects/patchbay/node_modules/patchbay-dark-crystal/views/new.js:98:25)
    at HTMLButtonElement.ev-click (/home/kyphae/projects/patchbay/node_modules/patchbay-dark-crystal/views/new.js:75:52)

Also followed by these two when clicking on the error tabs - these aren't Dark Crystal specific, are related to how Patchbay handles errors:

TypeError: Cannot read property 'dataset' of null
    at setInvisible (/home/kyphae/projects/patchbay/node_modules/hypertabs/lib/util.js:31:12)
    at blur (/home/kyphae/projects/patchbay/node_modules/hypertabs/tabs.js:26:3)
    at /home/kyphae/projects/patchbay/node_modules/hypertabs/tabs.js:59:18
    at each (/home/kyphae/projects/patchbay/node_modules/hypertabs/lib/util.js:12:5)
    at HTMLAnchorElement.onclick (/home/kyphae/projects/patchbay/node_modules/hypertabs/tabs.js:57:11)
TypeError: Cannot read property 'id' of null
    at history.filter.loc (/home/kyphae/projects/patchbay/app/html/tabs.js:43:54)
    at Array.filter (<anonymous>)
    at onClose (/home/kyphae/projects/patchbay/app/html/tabs.js:42:39)
    at close (/home/kyphae/projects/patchbay/node_modules/hypertabs/tabs.js:46:18)
    at HTMLAnchorElement.onclick (/home/kyphae/projects/patchbay/node_modules/hypertabs/tabs.js:77:9)
@m4gpi m4gpi added the bug Something isn't working label Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant