Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC1155 values to the public BigQuery dataset #315

Open
0x-jj opened this issue Feb 21, 2022 · 3 comments
Open

Add ERC1155 values to the public BigQuery dataset #315

0x-jj opened this issue Feb 21, 2022 · 3 comments

Comments

@0x-jj
Copy link

0x-jj commented Feb 21, 2022

Firstly I just want to say thanks for all the great work you have done on this and thanks for sharing it with the community!

We use the public BigQuery dataset to track token transfers and manage our internal NFT ownership state via the token_transfers table.

The dataset has transfer info for ERC20 and ERC721, but not ERC1155. For ERC721, the value field is the token id for the token transferred, for ERC20 it's actually the value.

I see there is already support for detecting ERC1155 transfers in the code - how can we get this information pushed to the public dataset and handle it in a similar way to ERC721? What is the process? If there is work associated I'm happy to do this, just let me know what it is.

Alternatively, if there is somewhere public I can pull transfers for 1155 please let me know!

@elie222
Copy link

elie222 commented May 20, 2022

This is the file that needs updating:
https://github.com/blockchain-etl/ethereum-etl/blob/develop/ethereumetl/service/token_transfer_extractor.py

Should be pretty simple. Basically erc1155 has more topics in the log. Right now these are skipped but don’t need to be

@elie222
Copy link

elie222 commented May 20, 2022

This file would also do with an update:
https://github.com/blockchain-etl/ethereum-etl/blob/develop/ethereumetl/service/eth_contract_service.py

Where you can check for erc1155 based on its transfer function that has an extra argument to represent tokenId

@elie222
Copy link

elie222 commented May 22, 2022

I made a PR for this here: #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants