-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR GitHub action build: two builds intended? #28
Comments
If you are doing a PR from your own repository, I guess, since it is intended that both internal branches without PRs and external PRs without internal branches run a build. I guess one of those could be disabled in the action, though. |
If you agree to have the push build only on branch main, I can open a PR for it. |
No, it is intended that pushes happen on all branches and on PRs. It can be considered a bug or and edge case than on an in-repo PR both builds are triggered, and a PR mitigating that would be merged. |
This doesn't seem to be easy to achieve with the current workflow syntax. This proposal would help. The only possibility apparently is a conditional implementation per job: https://github.com/orgs/community/discussions/57827. However, if the build runs for every push anyway, why would you even want to have the |
Yes, it is.
That is not only the only possibility, but the best one. The action in this repository only has a single job with a single step, so no repetition would be needed. |
In a pull request, the GitHub action runs twice (for push and for pull request):
Is this intended?
The text was updated successfully, but these errors were encountered: