Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for em and rem size units #743

Open
ayltai opened this issue Jul 13, 2021 · 0 comments
Open

Support for em and rem size units #743

ayltai opened this issue Jul 13, 2021 · 0 comments

Comments

@ayltai
Copy link

ayltai commented Jul 13, 2021 •
edited
Loading

size and defaultSize props do not currently support "em" and "rem" size units. See https://github.com/bokuweb/re-resizable/blob/master/src/index.tsx#L163

What is the reason for checking the size unit? Can we just check if its a number then return ${n}px. Otherwise, just return as is.
@ayltai ayltai changed the title Support for em size unit Support for em and rem size units Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayltai