Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #170

Open
Greyvend opened this issue Oct 6, 2020 · 1 comment
Open

Add type hints #170

Greyvend opened this issue Oct 6, 2020 · 1 comment

Comments

@Greyvend
Copy link

Greyvend commented Oct 6, 2020

When running mypy on the code that uses flaky, you get:

Skipping analyzing 'flaky': found module but no type hints or library stubs

Here is how it can be fixed.
@ssbarnea
Copy link

ssbarnea commented Mar 5, 2021

Untyped decorator makes function "test_prerun_reqs_v1" untyped

Can we please add type hints to flaky? Its a shame not to have type hints for a QA tool ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssbarnea @Greyvend