Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request(css): Make VPHighlight.vue#L66 Background Changeable from Component Props #29

Open
brenoepics opened this issue Oct 11, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@brenoepics
Copy link
Owner

The <span class="glowing-icon-glow"></span> element, which is used as the glowing icon on the home page, currently has a static background. To enhance flexibility and customization, it would be beneficial to make the background of this element changeable through component props.

Proposed Solution:

Modify the VPHighlight.vue component to accept a prop for the background color of the glowing icon.
Ensure that the default behavior remains unchanged if no prop is provided.
Benefits:

Allows for easy customization of the glowing icon's background without modifying the component's internal code.
Enhances the theme's flexibility and usability.
Example:

<VPHighlight glowingIcon="#ff0000" />

This would set the background of the glowing icon to red.

https://github.com/brenoepics/vitepress-carbon/blob/main/packages/theme/src/theme/components/VPHighlight.vue#L66

@brenoepics brenoepics added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant