Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using setTimeout with one time event no longer works #119

Closed
nmccann opened this issue Sep 16, 2015 · 2 comments
Closed

Using setTimeout with one time event no longer works #119

nmccann opened this issue Sep 16, 2015 · 2 comments

Comments

@nmccann
Copy link

nmccann commented Sep 16, 2015

Hi,

I recently noticed that one time events were no longer being executed, and eventually narrowed it down to the following this 5dcecba

The scheduleTimeout function seems to return early if there is no next occurrence (seems related to #103). Is this intentional?

An example of my schedule: Later.parse.recur().on(localDate.toDate()).fullDate()

I added an example of a failing test to a my fork: nmccann@e509ee9

I would also like to say thank you for the wonderful library, and I'm happy to see you're updating it again :)

Sidenote: When I'm running tests on the latest commit, it just says 10 passing (44ms), but on previous commits it would say 41709 passing (16s) 1 pending. I put a console.log in one of the tests but it didn't show up. It seems like its skipping some tests.

@bunkat bunkat closed this as completed in 90d6729 Sep 16, 2015
@bunkat
Copy link
Owner

bunkat commented Sep 16, 2015

Sorry about that, I think it should be fixed now (and thanks for the test case!). I'm glad that you find the library useful and appreciate the kind words. I consider this library pretty much done, so I doubt you'll see any big changes but I will continue to fix any bugs as they crop up.

@nmccann
Copy link
Author

nmccann commented Sep 17, 2015

Awesome, thank you for the quick response and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants