Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

won't work out of the box on windows #2

Open
zapashcanon opened this issue Aug 13, 2021 · 3 comments
Open

won't work out of the box on windows #2

zapashcanon opened this issue Aug 13, 2021 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@zapashcanon
Copy link
Contributor

Hi,

For a basic request, one will get an error on Windows because of missing SSL certs. It seems reasonable to me to expect it to work out of the box in an "ez" library.

I'll open a PR to show the failure in CI.

The easiest solution would be to load the certificates if Sys.os_type = "Win32" || Sys.os_type = "Cygwin" or something like that.

@c-cube c-cube added bug Something isn't working help wanted Extra attention is needed labels Aug 13, 2021
@c-cube
Copy link
Owner

c-cube commented Aug 17, 2021

that sounds reasonable, I'm just not sure how to do it and how to test it.

@zapashcanon
Copy link
Contributor Author

You can load the certificate with Curl.set_cainfo but I have no idea how to find the correct certificates...

About testing you could do it in hardcore mode (using only the CI :D) or using a free windows VM and then install OCaml on it.

Or we can cheat and ask @delthas to save us as he like windows. :)

@c-cube
Copy link
Owner

c-cube commented Aug 17, 2021

A VM is workable but I have very little free time right now, and using CI only is the stuff of nightmares :). CI is only good to prevent regressions imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants