Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToS acceptation #1542

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ToS acceptation #1542

wants to merge 4 commits into from

Conversation

lbesson
Copy link
Member

@lbesson lbesson commented Mar 3, 2023

This PR forces the validation of ToS

Existing users won't have tos_validated field set
On login, if user hasn't accepted ToS, a 403 with specific message will be returned (to be caught by UI)
The UI should ask to login again, with a small explanation + ToS checkbox

Once the login + accept ToS is done, the user can access camptocamp, and the date is stored in the db.

Note: do we know since when the ToS checkbox is there on register? We should skip this for such users (or more precisely, store a tos_validated field corresponding to user creation?)

@lbesson lbesson force-pushed the gcu branch 2 times, most recently from 1e34cfc to d22499f Compare March 6, 2023 15:37
@lbesson lbesson marked this pull request as ready for review March 6, 2023 15:44
c2corg_api/views/user.py Outdated Show resolved Hide resolved
@codacy-production
Copy link

codacy-production bot commented Mar 6, 2023

Coverage summary from Codacy

Merging #1542 (d090e22) into master (2d7199e) - See PR on Codacy

Coverage variation Diff coverage
0.00% 90.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2d7199e) 19797 18350 92.69%
Head commit (d090e22) 19824 (+27) 18374 (+24) 92.69% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1542) 30 27 90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@brunobesson
Copy link
Member

brunobesson commented Mar 6, 2023

Note: do we know since when the ToS checkbox is there on register? We should skip this for such users (or more precisely, store a tos_validated field corresponding to user creation?)

I'll check > it was released with v7.0.0 (c2corg/c2c_ui@20f296e). Released on Apr 1, 2019, don't remember exactly when it was deployed, but 7.0.2 was deployed on April 4, 2019.

@brunobesson
Copy link
Member

@lbesson what's the status on this? c2corg/c2c_ui#3838 does the frontend part. Could we merge this PR? Is there sil some work needed?

@lbesson
Copy link
Member Author

lbesson commented Feb 20, 2024

mostly asked to be put on hold by Loic, probably this should be fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants