-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToS acceptation #1542
base: master
Are you sure you want to change the base?
ToS acceptation #1542
Conversation
1e34cfc
to
d22499f
Compare
Coverage summary from CodacyMerging #1542 (d090e22) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
I'll check > it was released with v7.0.0 (c2corg/c2c_ui@20f296e). Released on Apr 1, 2019, don't remember exactly when it was deployed, but 7.0.2 was deployed on April 4, 2019. |
@lbesson what's the status on this? c2corg/c2c_ui#3838 does the frontend part. Could we merge this PR? Is there sil some work needed? |
mostly asked to be put on hold by Loic, probably this should be fine now |
This PR forces the validation of ToS
Existing users won't have tos_validated field set
On login, if user hasn't accepted ToS, a 403 with specific message will be returned (to be caught by UI)
The UI should ask to login again, with a small explanation + ToS checkbox
Once the login + accept ToS is done, the user can access camptocamp, and the date is stored in the db.
Note: do we know since when the ToS checkbox is there on register? We should skip this for such users (or more precisely, store a tos_validated field corresponding to user creation?)