Error on __dirname

[kuraga]

(node:12505) UnhandledPromiseRejectionWarning: Error: Could not load node-globals:dirname (imported by /home/sasha/rotorjs/node_modules/tman/lib/tman.js): Path must be a string without null bytes
    at /home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:21724:19
    at <anonymous>

Any thoughts?

[calvinmetcalf]

how are you using this ?

[kuraga]

@calvinmetcalf tman does

[calvinmetcalf]

is it being included in your rollup configs ?

[kuraga]

@calvinmetcalf what do you mean?

Error disappears since I remove __dirname from that line.

[calvinmetcalf]

this is a plugin for rollup, depending on your config when building your thing it may or may not be included in your build and thus error out

[kuraga]

UPDATED:

@calvinmetcalf ,
rollup-node-globals-issue.zip,
node build.js.

[calvinmetcalf]

put globals before resolve in your config

…

On Fri, Oct 5, 2018 at 9:39 AM Alexander Kurakin ***@***.***> wrote: @calvinmetcalf <https://github.com/calvinmetcalf> , build.js <https://gist.github.com/kuraga/6da398ce6cadefc4a3552a7bb255f929>, package.json <https://gist.github.com/kuraga/27c3321e3ea637c60ac138f48a633ee7>. And: import tman from 'tman'; tman.run();. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABE4n6I0_OZ1Lr0cru9KIkJwi8ox9PDEks5uh2EBgaJpZM4XJUbJ> .

[kuraga]

@calvinmetcalf , then:

Error: 'default' is not exported by node_modules/tman/lib/tman.js
    at error (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:3460:30)
    at Module.error (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:13361:9)
    at handleMissingExport (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:13048:21)
    at Module.traceVariable (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:13469:17)
    at ModuleScope.findVariable (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:12723:29)
    at MemberExpression$$1.bind (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:11244:50)
    at CallExpression.NodeBase.bind (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:9183:23)
    at CallExpression.bind (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:10234:31)
    at ExpressionStatement$$1.NodeBase.bind (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:9183:23)
    at Program.NodeBase.bind (/home/sasha/rotorjs/node_modules/rollup/dist/rollup.js:9179:31)

But it does...

[kuraga]

@calvinmetcalf Hm, interesting facts (on original code):

1. If code is import tman as tman; tman.run(); - we have an error.
2. If code is import tman as tman; tman.run(); and we remove __dirname here, - we don't have an error.
3. If code is import tman as tman; - we still have __dirname (and it's assignment) in the bundle but don't have an error!

[kuraga]

@calvinmetcalf but what does this error mean? Where does it come from? The error. Forget the context.

[calvinmetcalf]

the original error has to do with it not being able to find the stand in module we use for __dirname, not sure why...

[kuraga]

@calvinmetcalf , got part of this issue.

1. Original:
   a. Plugins order: resolve, commonjs, globals (and builtins)
   b. ECMAScript modules? Yes.
   c. Result: Error: Could not load node-globals:dirname (imported by /home/sasha/rotorjs/node_modules/tman/lib/tman.js): Path must be a string without null bytes.

2. Trying A:
   a. Plugins order: globals (and builtins), resolve, commonjs.
   b. ECMAScript modules? Yes.
   c. Result: Error: 'default' is not exported by node_modules/tman/lib/tman.js.

3. Trying B:
   a. Plugins order: globals (and builtins), resolve, commonjs.
   b. ECMAScript modules? No (building script.js instead of script.mjs, see here).
   c. Result: success!

4. Trying C:
   a. Plugins order: resolve, commonjs.
   b. ECMAScript modules? Yes.
   c. Result: no errors but unresolved symbols.

So, you were right:

put globals before resolve in your config

But this plugins order is incompatible (in my code) with ESM... And ESM works fine without your plugin.

[kuraga]

@calvinmetcalf ahaha, I got it!!! We have a new error since I set correct plugins order. See #20 , please!

[kuraga]

Null byte (\0) is really in these lines. It was introduced in #3 .

[kuraga]

Ah, ok, close in favor of #23 .