Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Osano Consent Banner CSS Style #4701

Open
antantunes opened this issue Dec 3, 2024 · 4 comments · May be fixed by #4767
Open

Remove Osano Consent Banner CSS Style #4701

antantunes opened this issue Dec 3, 2024 · 4 comments · May be fixed by #4767
Labels
component:docs Documentation improvements, including new or updated content

Comments

@antantunes
Copy link

antantunes commented Dec 3, 2024

We are updating the Style of the Osano consent banner in all our domains.

I would like to request the removal of the current CSS Style you have for the Osano Consnet banner on docs.camunda.io.

The new CSS will be added using GTM so that if in the future we need to change the styles we can do it without work from your team.

Urgency: Not Urgent

Deadline: Jan 2025

@pepopowitz
Copy link
Collaborator

The work here is to remove the Osano CSS styles defined in custom.css, which seems pretty straightforward.

Two questions @antantunes --

  1. We have a link in the footer of docs.camunda.io that reads "Cookie Preferences," and it opens a panel. That link currently has a CSS class named osano-footer-link-docu. I'd like to remove that CSS class, because it seems unnecessary, we already have a dedicated class for footer links. Do you know if that class name exists for some Osano logic to hook into the element? I don't see anything in our code that does so, and the panel opens due to the onclick handler, not something that's attaching based on a CSS selector. @akeller you may also have thoughts about this.
  2. The onclick handler for that link reads onclick="Osano.cm.showDrawer('osano-cm-dom-info-dialog-open')". That argument osano-cm-dom-info-dialog-open looks like it is also a CSS selector. We don't reference it in our code, nor is there a CSS class defining styles for it, but I'm wondering if that value needs to also change for any CSS updates you push out through GTM?

@akeller akeller added the component:docs Documentation improvements, including new or updated content label Dec 3, 2024
@akeller akeller moved this from 🆕 Inbox to 🔖 Ready in Developer Experience Dec 3, 2024
@akeller akeller moved this from 🔖 Ready to 📋 Backlog in Developer Experience Dec 3, 2024
@antantunes
Copy link
Author

Hi @pepopowitz , code to be deleted is everything after /* Osano Styles */

Regarding the class osano-footer-link-docu, thhe following page has the Osano documentation on how to add the cookie preferences link to the page. I don't see that class there so it should be something added to make the style of this link match the others on the footer.

https://docs.osano.com/hc/en-us/articles/22469660845204-Opening-the-Drawer-Storage-Preferences

I have tried removing the osano-footer-link-docu class and the link style changes. So I would say we need to keep the class.
image

Nothing should be changed on " onclick="Osano.cm.showDrawer('osano-cm-dom-info-dialog-open') ".

@pepopowitz
Copy link
Collaborator

Thanks @antantunes! I should have no problem getting to this next week -- does that timing work for you?

@antantunes
Copy link
Author

Hey @pepopowitz , I'm sorry for the delayed response. Yes that would work!

@pepopowitz pepopowitz linked a pull request Dec 12, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants