Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration support for zeebe user tasks #4573

Merged
merged 35 commits into from
Dec 6, 2024

Conversation

christinaausley
Copy link
Contributor

@christinaausley christinaausley commented Nov 5, 2024

Description

Relates to https://github.com/camunda/product-hub/issues/2126. Note that these are changes executing the following:

  • Ensure we clearly recommend Zeebe user tasks, and link to migration guide.
  • Update migration guide to use C8API instead of Zeebe REST API.
  • Consider new placement for migration content in APIs/tools in sidebar.
  • Explicitly state in migration guide why it is recommended to design a process with one implementation type.

The following will be added in a separate PR:

For 8.6

  • Document that user tasks with Job worker implementation are deprecated (but supported).

For 8.7

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added component:docs Documentation improvements, including new or updated content theme:api-streamline Issues related to the theme of streamlining APIs labels Nov 5, 2024
@christinaausley christinaausley self-assigned this Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

👋 🤖 🤔 Hello, @christinaausley! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/apis-tools/frontend-development/01-task-applications/02-user-task-lifecycle.md
  • docs/apis-tools/tasklist-api-rest/assets/img/api-architecture.png
  • docs/apis-tools/tasklist-api-rest/specifications/assign-task.api.mdx
  • docs/apis-tools/tasklist-api-rest/specifications/complete-task.api.mdx
  • docs/apis-tools/tasklist-api-rest/specifications/get-task-by-id.api.mdx
  • docs/apis-tools/tasklist-api-rest/specifications/search-tasks.api.mdx
  • docs/apis-tools/tasklist-api-rest/specifications/unassign-task.api.mdx
  • docs/components/concepts/process-instance-migration.md
These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.
  • versioned_docs/version-8.6/apis-tools/tasklist-api-rest/tasklist-api-rest-overview.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley
Copy link
Contributor Author

@aleksander-dytko @volodymyr-melnykc How do you feel about me moving the migration manual to a new section? See related.

If this is fine, I will apply it to 8.6 and 8.5 as well.

Note that we still need to change the migration manual to the C8 API instead of the Zeebe REST API in both 8.6 and next.

@christinaausley christinaausley added the deploy Stand up a temporary docs site with this PR label Nov 5, 2024
@volodymyr-melnykc
Copy link
Contributor

@aleksander-dytko @volodymyr-melnykc How do you feel about me moving the migration manual to a new section? See related.

@christinaausley Moving the migration manual to a new dedicated section under the "APIs & Tools" makes sense to me.

@github-actions github-actions bot temporarily deployed to camunda-docs November 5, 2024 11:38 Destroyed
@christinaausley
Copy link
Contributor Author

@volodymyr-melnykc I have started updating the endpoints in the Zeebe user task guide for the C8 API, but could you please make any final adjustments to the technical details you would like to make and I will backport?

@christinaausley christinaausley mentioned this pull request Nov 5, 2024
9 tasks
@christinaausley
Copy link
Contributor Author

Note that @volodymyr-melnykc and I are syncing this week on plans for this and https://github.com/camunda/product-hub/issues/2126.

@akeller akeller mentioned this pull request Nov 22, 2024
10 tasks
@@ -5,6 +5,12 @@ sidebar_position: 1
description: "Build applications for human-centered processes by querying user tasks, assigning users, and completing tasks with the Tasklist API."
---

:::note
Camunda introduced the [Camunda 8 REST API](/apis-tools/camunda-api-rest/camunda-api-rest-overview.md) with `8.6` to manage and query process entities such as processes, decisions, forms, and user tasks.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still accurate @volodymyr-melnykc?

@@ -5,6 +5,12 @@ sidebar_position: 1
description: "Build applications for human-centered processes by querying human tasks, assigning users, and completing tasks with the Tasklist API."
---

:::note
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment to double check here @volodymyr-melnykc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Camunda introduced Zeebe user tasks with 8.5 to build more advanced functionalities. If you use Zeebe user tasks with 8.5, task management endpoints in the Tasklist API will not work.

To manage Zeebe user tasks Camunda has introduced the Zeebe REST API, though you can still query Zeebe user tasks with the Tasklist API."

@christinaausley
Copy link
Contributor Author

@volodymyr-melnykc If this is accurate, this PR just requires your review and a few things to check for accuracy.

Could you please ensure the migration guide (changed from Zeebe REST to C8) is up to date and accurate?

Explicitly state in migration guide why it is recommended to design a process with one implementation type.

How would you like this to look in the documentation?

@github-actions github-actions bot temporarily deployed to camunda-docs December 4, 2024 14:59 Destroyed
@akeller
Copy link
Member

akeller commented Dec 4, 2024

@christinaausley will this be delivered with alpha2? Or still largely WIP? I'm trying to get a handle on when we can move forward with the API removal PRs (Zeebe REST API in this case).

@christinaausley
Copy link
Contributor Author

This can be merged as soon as @volodymyr-melnykc has a look -- he mentioned he will have time before the end of this week, so I can ensure the API removals also go out with the alpha next week. @akeller

@volodymyr-melnykc
Copy link
Contributor

I'm reviewing it currently.
Regarding the delivery date for these docs. The related product epic has been moved to alpha3. Should we also aim to deliver the docs in alpha3?
@christinaausley @akeller

@volodymyr-melnykc
Copy link
Contributor

volodymyr-melnykc commented Dec 6, 2024

@christinaausley I reviewed the changes (they looked good!) and updated several more details:

  • The task application architecture doc
  • The migration guide to the Camunda (Zeebe) user task
  • Renamed "Zeebe user task" and "Camunda user task"
  • Note that embedded forms are supported only by Job worked-based user tasks

Please review!

The doc for user task migration is called "migrate-to-zeeb-user-task.md". Since the implementation type is renamed to "Camunda user task", should we update the name of the file as well?

cc @akeller

@akeller
Copy link
Member

akeller commented Dec 6, 2024

I'm reviewing it currently. Regarding the delivery date for these docs. The related product epic has been moved to alpha3. Should we also aim to deliver the docs in alpha3? @christinaausley @akeller

@volodymyr-melnykc, just confirming, there will be no end user changes that we should document in this context for alpha2?

I would love to see if get these docs in a good place to merge ASAP, or in this case, shortly after alpha2 if possible. We have many changes coming in alpha3 and the race to get things done for 8.7. If there is a way we can ship these docs changes incrementally to keep things moving, let's do that.

@christinaausley
Copy link
Contributor Author

Perhaps I did not communicate clearly enough in the PR description, but this PR is solely for changes with 8.5 and 8.6, which are changes that can likely already be merged in. I have plans to adjust all of the required changes in next in a separate PR.

With this in mind, could you please review my changes to the versioned docs @volodymyr-melnykc? I will sift your additional changes in next into a separate PR.

@christinaausley
Copy link
Contributor Author

Changes specifically for Zeebe to Camunda user tasks will be covered in #4723, alongside the following:

For 8.6

  • Document that user tasks with Job worker implementation are deprecated (but supported).

For 8.7

@volodymyr-melnykc Please review this PR -- my expectation is that all of these changes can go live and be merged now? Changes for next are still a WIP.

Lastly, can your changes to the specifications be merged and live as well? Is this work already complete? If so, should this also be backported?

Thank you for your assistance and apologies for the back and forth on this.

@volodymyr-melnykc
Copy link
Contributor

@christinaausley Your changes look good and we can merge!

The changes that I made are related to the ongoing updates in the product epic (https://github.com/camunda/product-hub/issues/2126). They're for the "next". I don't see risks in merging them as well, though there will be more follow-ups (which we can do later).

@github-actions github-actions bot temporarily deployed to camunda-docs December 6, 2024 20:27 Destroyed
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one non-blocking comment (as we can address the Tasklist REST API note in a future PR).

@christinaausley christinaausley merged commit a5a10a0 into main Dec 6, 2024
8 checks passed
@christinaausley christinaausley deleted the migration-support-zeebe-user-task branch December 6, 2024 21:29
Copy link
Contributor

github-actions bot commented Dec 6, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR theme:api-streamline Issues related to the theme of streamlining APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants