-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(self-managed): OpenShift ROSA instructions and rework of the reference arch for OpenShift #4734
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small copy edits and left a non-blocking suggestion - I love the reusable structure of these guides, makes the content much easier to read and review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller requests, I only reviewed the next part and would assume 8.6 is the same.
Overall looks quite good 🚀.
I did not try to follow it step by step, let me know if I should run through it all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick adjustments, the only thing I'd probably change is the AWS CLI recommendation still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few grammar edits and left a small comment regarding wording but otherwise this looks to be in a good place to me. Approving regardless, just let me know if anything else gets updated and this needs a final thumbs up. 👍
docs/self-managed/setup/deploy/amazon/openshift/terraform-setup.md
Outdated
Show resolved
Hide resolved
…p.md Co-authored-by: Cole Isaac <[email protected]>
ec3911b
The preview environment relating to the commit e79b6a4 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4734/index.html |
Description
This PR revises the installation instructions for Camunda 8 on OpenShift, taking into account versions 8.7 and 8.6.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).