Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove osano styles #4767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pepopowitz
Copy link
Collaborator

Description

Closes #4701.

Removes the Osano styles, so that they can be customized on a third party platform.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@pepopowitz pepopowitz added the component:docs Documentation improvements, including new or updated content label Dec 12, 2024
@pepopowitz pepopowitz self-assigned this Dec 12, 2024
@pepopowitz
Copy link
Collaborator Author

@antantunes please let me know if there's a specific date I should merge/release this.

@@ -328,7 +328,7 @@ module.exports = {
href: "https://legal.camunda.com/privacy-and-data-protection",
},
{
html: `<a class="osano-footer-link-docu" href="#" onclick="Osano.cm.showDrawer('osano-cm-dom-info-dialog-open')">Cookie Preferences</a>`,
html: `<a class="footer__link-item" href="#" onclick="Osano.cm.showDrawer('osano-cm-dom-info-dialog-open')">Cookie Preferences</a>`,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the CSS class that all the other footer links are using, which looks the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

Remove Osano Consent Banner CSS Style
1 participant