You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we've expanded and improved our shell completions, code duplication and room for improvement has increased across lxc/completion.go.
Refactorings and improvements to consider:
Extract common logic into separate functions;
Expand usage of map[string]struct{} to improve lookup times;
Audit use of completion directives and ensure consistency across CLI commands and sub commands (ShellCompDirectiveNoFileComp and ShellCompDirectiveNoSpace);
As we've expanded and improved our shell completions, code duplication and room for improvement has increased across
lxc/completion.go
.Refactorings and improvements to consider:
map[string]struct{}
to improve lookup times;ShellCompDirectiveNoFileComp
andShellCompDirectiveNoSpace
);lxc config
andlxc profile
shell completions #14542 (comment) and CLI: Improvements tolxc config
andlxc profile
shell completions #14542 (comment));The text was updated successfully, but these errors were encountered: