-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal zoom #3825
Terminal zoom #3825
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3825 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 256 256
Lines 14584 14584
=======================================
Hits 12972 12972
Misses 1612 1612 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one suggestion regarding DRY
5b6f110
to
b422b72
Compare
b9be1ef
to
1386232
Compare
b422b72
to
239cb3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! Just a question/issue about alternative keyboard layouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Seems i missed LogicalKeyboardKey.add
, oops. Good job adding the numpad support too!
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds the ability to change the font size in the GUI terminals, using common shortcuts like
Ctrl
++
to increase,Ctrl
+-
to decrease andCtrl
+0
to reset.Command
is used instead ofCtrl
on macOS.It also include two small, drive-by fixes, which change the deprecated
MaterialStateColor
with the newerWidgetStateColor
. Those were done because they were in the same files as the other, relevant changes.MULTI-1678