Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal zoom #3825

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Terminal zoom #3825

merged 3 commits into from
Dec 12, 2024

Conversation

andrei-toterman
Copy link
Contributor

This PR adds the ability to change the font size in the GUI terminals, using common shortcuts like Ctrl++ to increase, Ctrl+- to decrease and Ctrl+0 to reset. Command is used instead of Ctrl on macOS.

It also include two small, drive-by fixes, which change the deprecated MaterialStateColor with the newer WidgetStateColor. Those were done because they were in the same files as the other, relevant changes.

MULTI-1678

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (1386232) to head (4afcbbb).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3825   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         256      256           
  Lines       14584    14584           
=======================================
  Hits        12972    12972           
  Misses       1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

levkropp
levkropp previously approved these changes Dec 9, 2024
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one suggestion regarding DRY

src/client/gui/lib/platform/linux.dart Show resolved Hide resolved

Verified

This commit was signed with the committer’s verified signature.
andrei-toterman Andrei Toterman

Verified

This commit was signed with the committer’s verified signature.
andrei-toterman Andrei Toterman
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! Just a question/issue about alternative keyboard layouts.

src/client/gui/lib/platform/linux.dart Show resolved Hide resolved

Verified

This commit was signed with the committer’s verified signature.
andrei-toterman Andrei Toterman
Sploder12
Sploder12 previously approved these changes Dec 11, 2024
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems i missed LogicalKeyboardKey.add, oops. Good job adding the numpad support too!

Base automatically changed from crlf-to-lf to main December 11, 2024 23:19
@andrei-toterman andrei-toterman dismissed Sploder12’s stale review December 11, 2024 23:19

The base branch was changed.

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrei-toterman andrei-toterman added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit c3ff915 Dec 12, 2024
14 checks passed
@andrei-toterman andrei-toterman deleted the terminal-zoom branch December 12, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants