Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] make renovate ask for users instead of team for reviews #3844

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

andrei-toterman
Copy link
Contributor

Apparently, when asking for a team, it asks for the whole team, not just users within that team. The good news is that now we can specify exactly which users from the team qualify for reviews. The bad news is that we must update this list as part of the onboarding/offboarding process 🤷

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (a516c93) to head (f7411ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3844   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         256      256           
  Lines       14584    14584           
=======================================
  Hits        12972    12972           
  Misses       1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ricab ricab added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 7074116 Dec 16, 2024
14 checks passed
@ricab ricab deleted the renovate-ask-reviewers branch December 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants