Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx_server_name config options #61

Open
vedant1811 opened this issue Mar 25, 2015 · 1 comment
Open

nginx_server_name config options #61

vedant1811 opened this issue Mar 25, 2015 · 1 comment

Comments

@vedant1811
Copy link

The nginx_server_name config works as specified apparently but there are downsides to it.

If I do not set anything, it defaults to the IP used to deploy. This may be undesirable (was for me). I wanted this field to be not set altogether so that my app replies to server IP, mydomain.com, www.mydomain.com and also the EC2 domain. This behaviour actually broke my production app; I did not encounter this problem in staging as I was using the IP itself in the browser.

Also, I was unable to set it to multiple values, like:
set :nginx_server_name, 'mydomain.com www.mydomain.com'

Not setting it and/or setting multiple values may be out of convention but seems like a desirable feature. Even if you don't add it, reflect this behaviour in the docs. Regards.

@rhomeister
Copy link
Contributor

Happy to accept a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants