You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 26, 2022. It is now read-only.
Right now, a single rule is selected to determine whether or not checks-out see sufficient approvals to accept a PR. When working in a monorepo, this isn't sufficient; different paths in the same project will have different approval rules, and you don't know ahead of time which combination of them need to be active for a given PR. Adding the ability to specify that multiple approval rules can be active at once, determined per-PR would enable a flexible monorepo approval system.
The text was updated successfully, but these errors were encountered:
My quick scan of how CODEOWNERS works is that is per-branch. The way I am thinking about it, monorepo support needs to be per-path. But I can be convinced that I am wrong. I was wrong; we can use this to specify owners per-path, per-branch.
I have a different potential early implementation of monorepo support, but I need to find out from the Open Source Office how to get the code here. But maybe it should be abandoned to meet this instead.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now, a single rule is selected to determine whether or not checks-out see sufficient approvals to accept a PR. When working in a monorepo, this isn't sufficient; different paths in the same project will have different approval rules, and you don't know ahead of time which combination of them need to be active for a given PR. Adding the ability to specify that multiple approval rules can be active at once, determined per-PR would enable a flexible monorepo approval system.
The text was updated successfully, but these errors were encountered: