Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3407] Bump to ghc 9.8.2 #4607

Closed
wants to merge 12 commits into from
Closed

[ADP-3407] Bump to ghc 9.8.2 #4607

wants to merge 12 commits into from

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented May 24, 2024

  • Bump int-cast
  • Bump openapi3
  • Remove all constraints in cabal files
  • Bump compiler in haskell.nix to 9.8.2

@paolino paolino added the CI CI related label May 24, 2024
@paolino paolino self-assigned this May 24, 2024
@paolino paolino force-pushed the paolino/bump-hls-to-2.8.0.0 branch 5 times, most recently from 0d94e01 to be42bc1 Compare June 4, 2024 15:02
Base automatically changed from paolino/bump-hls-to-2.8.0.0 to master June 4, 2024 18:36
@paolino paolino force-pushed the paolino/ghc-9.8.2 branch 3 times, most recently from 59e66db to 7f07e26 Compare June 5, 2024 14:57
@paolino paolino marked this pull request as ready for review June 5, 2024 16:11
jonathanknowles
jonathanknowles approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've tested it locally, and:

  • everything seems to build just fine. 🎉
  • HLS continues to work nicely. 🎉

Hopefully it will also work for others too!

cabal.project Show resolved Hide resolved
Anviking
Anviking approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cabal build all in nix shell and HLS works on my mac

HeinrichApfelmus
HeinrichApfelmus approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cabal build all in nix shell and HLS works on my mac

Same for me. 👍

paweljakubas
paweljakubas approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paolino paolino force-pushed the paolino/ghc-9.8.2 branch from 7f07e26 to 859e8b1 Compare July 1, 2024 13:46
@Anviking Anviking force-pushed the paolino/ghc-9.8.2 branch 3 times, most recently from 859e8b1 to b510141 Compare July 10, 2024 12:34
@paolino paolino force-pushed the paolino/ghc-9.8.2 branch from b510141 to 0cd7cac Compare August 9, 2024 16:04
@paolino paolino changed the base branch from master to paolino/ADP-3407/bump-ghc-version-9.6.6 August 9, 2024 16:05
@paolino paolino changed the title Bump to ghc 9.8.2 [ADP-3407] Bump to ghc 9.8.2 Aug 9, 2024
Base automatically changed from paolino/ADP-3407/bump-ghc-version-9.6.6 to master August 9, 2024 17:19
HeinrichApfelmus and others added 12 commits November 1, 2024 12:00
@HeinrichApfelmus @paolino
Fix compiler error in Cardano.Read.Ledger.Block.Txs
a5523b8
@paolino
Bump hackage dependency
755e79e
@paolino
Bump haskell nix dependency
369278a
@paolino
Bump compiler to ghc 9.6.6
7c3f865
@paolino
Bump hackage index
c179def
@paolino
Fix new hlint issues
948d3c4
@paolino
Bump mdbook-admonish assets to 3.0.0
3c0aece
@paolino
Bumps for ghc 9.8.2
538cda7
@paolino
Tweaks to allow 9.8.2 compilation
19bc779
@jonathanknowles @paolino
Use patched version of package wai.
cd2b8ca 
Fixes:
https://buildkite.com/cardano-foundation/cardano-wallet/builds/5240#01900a67-445e-447e-b1bd-976ebaf665c1/39-41

Error:
```
> Network/Wai/Application/Static.hs:260:27: error: [GHC-87897]
>     • Exception when trying to run compile-time code:
>         Z:\build\wai-app-static-3.1.9\images/folder.png: withBinaryFile: invalid argument (Bad file descriptor)
>       Code: (makeRelativeToProject "images/folder.png" >>= embedFile)
>     • In the untyped splice:
>         $(makeRelativeToProject "images/folder.png" >>= embedFile)
>     |
> 260 |             L.fromChunks [$(makeRelativeToProject "images/folder.png" >>= embedFile)]
>     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@jonathanknowles @paolino
Use patched version of package fgl.
2b21925 
Fixes:
```
Data/Graph/Inductive/Monad.hs:23:1: error: [GHC-87897]
    • Exception when trying to run compile-time code:
        External interpreter terminated (-15)
    • In the annotation:
        {-# ANN module "HLint: ignore Redundant lambda" #-}
   |
23 | {-# ANN module "HLint: ignore Redundant lambda" #-}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[10 of 29] Compiling Data.Graph.Inductive.NodeMap ( Data/Graph/Inductive/NodeMap.hs, dist/build/Data/Graph/Inductive/NodeMap.o )
[11 of 29] Compiling Data.Graph.Inductive.PatriciaTree ( Data/Graph/Inductive/PatriciaTree.hs, dist/build/Data/Graph/Inductive/PatriciaTree.o )
```
@paolino
Remove benchmarks from windows test bundle
8eb7603
@abailly
Copy link
Collaborator

abailly commented Dec 10, 2024

We should probably bump to whatever version the currently supported node (10.1.3) is using, which is not totally obvious from their repository...

@abailly
Copy link
Collaborator

abailly commented Dec 10, 2024

current supported ghc version for 10.1.3 is 8.10.7: https://github.com/IntersectMBO/cardano-node/releases/tag/10.1.3
Closing this outdated RP

@abailly abailly closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

@Anviking Anviking Anviking approved these changes

@jonathanknowles jonathanknowles jonathanknowles approved these changes

Assignees

@paolino paolino

Labels
CI CI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paolino @abailly @jonathanknowles @Anviking @HeinrichApfelmus @paweljakubas