CIP-0129 support #4879
Open
CIP-0129 support #4879
+99
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
7941ae8 to
74b0689
Compare
paweljakubas
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
c147de1 to
a1de81e
Compare
Note that we spent time trying to have a unique DRep keys schema representing both keys and scripts hashes but for reasons unknown to the mere mortals, bump.sh kept rejecting our changes hence why we resorted to keeping the 2 types but with identical underlying representations.
abailly
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
8fae5bd to
be83ff0
Compare
abailly
approved these changes
Dec 13, 2024
| , (T.replicate 65 "1", msg1) | ||
| , ("something", msg1) | ||
| , ("no-confidence", msg1) | ||
| , ("drep15k6929drl7xt0spvudgcxndryn4kmlzpk4meed0xhqe25nle07s",msg2) --28-byte payload without byte prefix correct hrp prefix |
There was a problem hiding this comment.
Suggestion: use a descriptive name instead of the hard coded value + comment
, (payloadWithoutCorrectBytePrefix, msg2)
where
payloadWithoutCorrectBytePrefix = "drep15k6929drl7xt0spvudgcxndryn4kmlzpk4meed0xhqe25nle07s"
=> no need for a comment
paweljakubas
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
67e2085 to
8b5d36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for https://github.com/cardano-foundation/CIPs/tree/master/CIP-0129
It adds specified in CIP-0129 prefixes for drep in case of script and key hash credentials.
The change required to remove
drep_scriptHRP that was used preciously for drep script hashes.All unit tests, generators therein and golden data was regenerated.
Comments
Issue Number
#4855