Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config default_autotype='pass' is not work #227

Open
minizilla opened this issue Mar 31, 2023 · 1 comment
Open

Config default_autotype='pass' is not work #227

minizilla opened this issue Mar 31, 2023 · 1 comment

Comments

@minizilla
Copy link

When I use autotype: pass inside password, it's work as intended. But if i set default_autotype='pass' inside config file and the password doesn't specify autotype it doesn't work, the behavior back to autotype: user :tab pass.

moviuro added a commit to moviuro/rofi-pass that referenced this issue Apr 8, 2023
The file "analyzer" was checking whether the pass file contained an
"autotype" field: if it did, it would do nothing; and if it didn't, then
it would use a hardcoded "autotype" value (user :tab pass).

This caused issues down the line because the code that would use the
config's values would always find an existing "autotype" value (whether
hardcoded in rofi-pass or supplied by the pass file), and would never be
able to apply the settings from the config file.

I would suggest (re)-using the fields ("autotype" in that case) with
values in order of preference; but for the moment, this patch does the
job.

1. autotype="user :tab pass" # hardcoded
2. if config exists and supplies it, then autotype="whatever is in
   config"
3. if the pass file supplies it, then autotype="whatever is in pass
   file"

Fixes carnager#227
@moviuro
Copy link
Contributor

moviuro commented Apr 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants