When no PR is assigned, hubot repeats itself

[davesade]

With new version there seems to be another bug hidden. Sadly, I couldn't find it.

Current version:

  setInterval(=>
    mergePullRequests robot
  , interval * 1000)

mergePullRequests = (robot, res) ->
  github.issues.getAll {}, (err, resp) ->
    issues = resp.data
    return notify robot, res, "No pull requests have been assigned to me." if not issues.length

Previously working version:

  setInterval(=>
    do mergePullRequests
  , interval * 1000)

mergePullRequests = (res) ->
  github.issues.getAll {}, (err, resp) ->
    issues = resp.data
    return notify res, "No pull requests have been assigned to me." if not issues.length

Not sure, where else this issue could be.

Temporary workaround: assign any dummy PR to Hubot. Then it checks for merges, but writes nothing into channel.