Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong react native version #24

Open
francesco-clementi-92 opened this issue Nov 12, 2021 · 6 comments
Open

Wrong react native version #24

francesco-clementi-92 opened this issue Nov 12, 2021 · 6 comments

Comments

@francesco-clementi-92
Copy link

  • I'm submitting a ...
    [X ] bug report

  • Summary
    After creating the app and starting on expo goapp android:
    Warning: Invalid version [email protected] for expo sdkVersion 43.0.0. Use [email protected]

@blixit
Copy link

blixit commented Nov 12, 2021

I had the same issue yesterday !

you need to update the package.json with right version and run "expo install" to apply the changes.

@cawfree
Copy link
Owner

cawfree commented Nov 17, 2021

@blixit Thanks for suggesting the fix; can you submit a PR or show your changes so I can deploy a fix here? 🙏

@blixit
Copy link

blixit commented Nov 18, 2021

I can do that this weekend

@blixit
Copy link

blixit commented Nov 21, 2021

After investigation, the bad version comes from the execution of npx create-react-native-app ${name} -t with-typescript in the createBaseProject() function from src/buidler/index.ts.

The template with-typescript is defined here https://github.com/expo/examples/tree/master/with-typescript. You can see that it contains the version 0.64.2.

16 days ago, a pull request has been merged to upgrade the package to make it compatible with Expo SDK 43: expo/examples#339 but the react-native version changed from this moment. Expo has already made the change here 11 days ago.

We have 2 ways to fix our issue:

  • fixing the version of react-native in the builder by setting 'dependencies.react-native': '^0.64.3' but i'm not a fan of this solution which makes this package more dependant to expo.
  • submit a PR to Expo examples and wait: this is what I'm going to do.

@blixit
Copy link

blixit commented Nov 21, 2021

I submitted the PR: expo/examples#342

@blixit
Copy link

blixit commented Nov 23, 2021

@francesco-clementi-92 @cawfree my PR has been merged. There is no need to update the current package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants